Skip to content

[FIX] Play Store crash: FragmentManager is already executing transactions #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joragua merged 2 commits into from
Jun 4, 2026
+11 −4
Merged

[FIX] Play Store crash: FragmentManager is already executing transactions #4879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e202a2c
fix: prevent crashes during detail fragment navigation
joragua Jun 3, 2026
de8464a
chore: add calens file
joragua Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/4879
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Crash from Google Play Console in FileDetailsFragment

To prevent crashes, the navigation logic when navigating back has been
improved, especially in cases where the observed file is null.

https://github.com/owncloud/android/issues/4737
https://github.com/owncloud/android/pull/4879
4 changes: 2 additions & 2 deletions ...dApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Aitor Ballesteros Pavón
* @author Jorge Aguado Recio
*
* Copyright (C) 2025 ownCloud GmbH.
* Copyright (C) 2026 ownCloud GmbH.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2,
Expand Down Expand Up @@ -610,7 +610,7 @@ class FileDetailsFragment : FileFragment() {
file = ocFileWithSyncInfo.file
updateDetails(ocFileWithSyncInfo)
} else {
requireActivity().onBackPressed()
requireActivity().onBackPressedDispatcher.onBackPressed()
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @author Jorge Aguado Recio
*
* Copyright (C) 2011 Bartek Przybylski
* Copyright (C) 2025 ownCloud GmbH.
* Copyright (C) 2026 ownCloud GmbH.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2,
Expand Down Expand Up @@ -543,7 +543,7 @@ class FileDisplayActivity : FileActivity(),
if (second != null) {
val tr = supportFragmentManager.beginTransaction()
tr.remove(second)
tr.commitNow()
tr.commit()
}
updateFragmentsVisibility(false)
updateToolbar(null)
Expand Down
Loading