Added sorting by name, date or size ascending/descending by tobiasKaminsky · Pull Request #624 · owncloud/android

tobiasKaminsky · 2014-09-14T13:55:15Z

Hello,
I have added the possibility to sort files/folders by name, date or size.
The option is stored temporary, so it is obeyed if the directory is changed.

Filename sorting fixes also #379
Sorting by size: Folder are sorted by name, as there is no information about the number of files containing the directory.

Sorting is, like dolphin or windows explorer, separated between folder and files.

TODO: Translate to other languages.

davivel · 2014-09-15T07:19:18Z

This is something to discuss with @jancborchardt . An screenshot would be appreciated.

Forget about translations, we only define English in development. Translations are done in and pulled from Transifex , synchronized daily with the branch 'develop'.

tobiasKaminsky · 2014-09-15T07:47:34Z

I have made three screenshots:

enhanced file sorting
"Sorting" option after clicking on the three points
available sorting options:

Filename - ascending
Filename - descending
Date - ascending
Date - descending
Filesize - ascending
Filesize - descending

jancborchardt · 2014-09-15T09:08:15Z

Nice, this look good!

@tobiasKaminsky one thing: The words »ascending« and »descending« are quite confusing. Instead use the more understandable labels:

Name, A-Z
Name, Z-A
Date, newest first
Date, oldest first
Size, biggest first
Size, smallest first

jancborchardt · 2014-09-15T09:08:24Z

cc @MTRichards

tobiasKaminsky · 2014-09-15T10:03:28Z

I have added a small change:
Now the folders are always on top and get sorted, then the files are displayed.
Before that it occured that the folders were on the bottom as the list was only reversed.
Now the behaviour is exactly the same like in dolphin (KDE file browser).

One thing left: When "Sorting by size" all folders stay in A-Z order as there is no information how big/many files they have. One could iterate over every folder and sum up its content, but this is maybe too much, or?

jancborchardt · 2014-09-15T10:42:52Z

@davivel don’t we have the folder size info by now? The web client displays it with no problems. cc @icewind1991 on how we do that there.

jancborchardt · 2014-09-15T10:45:42Z

@tobiasKaminsky in the list of the sorting options – let’s actually cut it down to 3:

A - Z
Newest - Oldest
Biggest - Smallest

The reverse orders are of little use and clutter up the list.

jancborchardt · 2014-09-15T10:46:22Z

And if we don’t have the folder size info for now, we can start out with the »A - Z« and »Newest - Oldest« sorting options.

jancborchardt · 2014-09-15T10:46:42Z

By the way, they should be styled as radio buttons so it’s obvious which one is currently active.

tobiasKaminsky · 2014-09-15T11:25:00Z

Radio buttons are done (I will add it later when the other questions are solved)
I personally like the possibility to reverse the sorting order as otherwise one has to scroll down the complete list. Currently I am thinking about a global switch, which is located on the bottom (or top) of the dialog called "reverse", which is a toggle button. What do you think?

MTRichards · 2014-09-15T11:49:08Z

Great stuff here.

@jancborchardt the issue with folder size was one of performance, if I remember. I don't know if we can get folder size directly from the server, or if we have to create it locally - if I remember, the issue was that we had to calculate it, which takes time with each sub folder query of the server - and gets worse the bigger the tree.

@davivel Is this still the case?

MTRichards · 2014-09-15T12:17:39Z

I personally like the possibility to reverse the sorting order as otherwise one has to scroll down the complete list. Currently I am thinking about a global switch, which is located on the bottom (or top) of the dialog called "reverse", which is a toggle button. What do you think?

I do like the reverse order - and your thought removes clutter.
@jancborchardt ?

tobiasKaminsky · 2014-09-15T12:31:07Z

@jancborchardt the issue with folder size was one of performance, if I remember. I don't know if we can get folder size directly from the server, or if we have to create it locally - if I remember, the issue was that we had to calculate it, which takes time with each sub folder query of the server - and gets worse the bigger the tree.

For test reasons I have added recursive function I have found on stackoverflow. It is only calculating the local folder size. But it seems very quick.
Or does it have to be the size of the folder on the server?

jancborchardt · 2014-09-15T12:54:23Z

Let’s start small with just the one order and leave out the reverse, ok? Small steps please, we can always add it later if we feel it is necessary.

- Folder size is computed locally (therefore only downloaded files are obeyed)

tobiasKaminsky · 2014-09-15T14:05:44Z

Let’s start small with just the one order and leave out the reverse, ok? Small steps please, we can always add it later if we feel it is necessary.

Right. I have removed the other options.
Folder size is computed locally.

davivel · 2014-09-17T16:36:45Z

Sorry for coming late.

About the size of folders, I think it is currently returned by the server in the property < d:quota-used-bytes > , but I am not sure, the name is a bit confusing. I would appreciate confirmation about this. CC @DeepDiver1975 @PVince81 .

@tobiasKaminsky , about your solution with local size of folders, probably won't work. The primary reason why we removed in the past the size of folders was not performance, but lack of synchrony with the real size in the server until the user browses down through all the tree of files or a full account synchronization is performed. With the local folder size the lack of synchrony is bigger, since will only match the server when all the files are downloaded (and synchronized).

jancborchardt · 2014-09-17T16:56:14Z

@tobiasKaminsky by the way, you should join us on IRC in #owncloud-android (freenode IRC)! :)

davivel · 2014-09-17T17:16:49Z

Yes, now I have a bouncer, so should not lost any more messages :$

tobiasKaminsky · 2014-09-18T07:16:21Z

About the size of folders, I think it is currently returned by the server in the property , but I am not sure, the name is a bit confusing. I would appreciate confirmation about this.
As far as I have found, the data are transferred via WebDav (ReadRemoteFolderOperation:79)
On the webdav interface via Browser (e.g. /remote.php/webdav/temp/) there is no file size.

Regarding the difference between local and server folder size:
I thought of this use case: Trying to find out which folder consume the most local size and then maybe delete them in order to get more space. But you are right, it is not mentioned that it is the local size which could confuse user.
So we should use the server folder size. But where is it? ;)

tobiasKaminsky · 2014-09-18T08:58:03Z

i have found something
in 049f659 @masensio has removed a function that gets the folder size from the server...
Maybe we can re-activate this and test the function?

DeepDiver1975 · 2014-09-18T09:02:20Z

About the size of folders, I think it is currently returned by the server in the property < d:quota-used-bytes > , but I am not sure, the name is a bit confusing. I would appreciate confirmation about this. CC @DeepDiver1975 @PVince81 .

Folder size does not exist in the webdav standard

DeepDiver1975 · 2014-09-18T09:04:41Z

Folder size does not exist in the webdav standard

but there is an owncloud extension to the standard:
owncloud/core#10723

😉 🚀

davivel · 2014-09-18T09:23:19Z

That's cool!!!

But I still do not understand what < d:quota-used-bytes > is. I cannot find it in Webdav standards, but seem to match the value of folders size.

davivel · 2014-09-18T09:26:30Z

@tobiasKaminsky , that removed code is the one I mentioned before that does not work fine; it is calculating the folder size from size of descendent files -- but with the current known value of that sizes. If a file several levels down the way of the current file changed, that size won't be synchronized until the user browses down, and the size of its folder ancestor in the current folder will be calculated from a not synchronized value.

jancborchardt · 2014-10-10T16:54:43Z

Yup, let’s move fast and iterate. No need to wait for folder size calculation, sorting by date and name is already great! :)

calculation

tobiasKaminsky · 2014-10-11T07:16:21Z

Ok.
Then I am done here :)
Please test and then it can be added to develop.

In order to get things clear it should exist a new issue for sorting by size, which refers to the "server-side folder size calculation" task. Otherwise it will maybe get forgotten?

jancborchardt · 2014-10-13T08:43:16Z

@davivel @jabarros @rperezb please test ^

davivel · 2014-10-14T07:56:48Z

I'm on it.

davivel · 2014-10-17T11:21:05Z

src/com/owncloud/android/ui/activity/FileDisplayActivity.java

Is there any specific reason to pass getApplicationContext() instead of 'this' ? If the answer is 'no', 'this' should be prefered.

davivel · 2014-10-17T12:35:43Z

Sorry for the delay, I had to swtich to other tasks.

Finished the code review, please, check my comments.

Additionally, a rebase on develop is needed before testing, BUT not before we merge the release-1.6.0 branch into master & develop. We will do this on Monday.

tobiasKaminsky · 2014-10-17T19:29:24Z

I have committed all your requested changes.

davivel · 2014-10-20T07:31:32Z

src/com/owncloud/android/ui/adapter/FileListListAdapter.java

Did you enable auto formatting? We'd rather it's disabled until we unify an official formatter. This makes harder the reviews.

Yes. It was a try to get automatically lines < 120 characters.
But it has changed to much, so I disabled it.

davivel · 2014-10-21T08:03:14Z

Thanks for the updates. The code review is fine for me now.

Please, rebase on 'develop' branch so that @purigarcia may validate the functionality.

davivel · 2014-10-24T11:13:40Z

We wanted to push this a bit up, so we rebased on 'develop' ourselves, in the branch 'sort_files'.

I close this PR to replace it with a #676

tobiasKaminsky · 2016-05-04T15:55:19Z

@davivel I have created a PR to use the folder size of the server: #1655

tobiasKaminsky added 2 commits September 14, 2014 15:51

Added sorting by name, date or size ascending/descending

20cd00b

Added forgotten Comparator

1df7a8c

tobiasKaminsky added 2 commits September 15, 2014 11:42

Renamed sorting labels

c98f2b5

Keep folders on top

0523ec4

- Only three orders: A-Z, Big-Small, New-Old.

a622b1d

- Folder size is computed locally (therefore only downloaded files are obeyed)

tobiasKaminsky mentioned this pull request Sep 18, 2014

Sorting is off for filenames with (2) numbers in parentheses #379

Closed

- disabled sort by size until server supports server-side folder size

706a769

calculation

davivel reviewed Oct 17, 2014
View reviewed changes

- requested changes by review by davivel

bc3f8b3

- added lgpgl

524a6e2

davivel reviewed Oct 20, 2014
View reviewed changes

- added requested changes

bc4a7bf

tobiasKaminsky mentioned this pull request Oct 24, 2014

feature request: auto-rename for Photo-upload #649

Closed

davivel closed this Oct 24, 2014

rperezb mentioned this pull request Mar 12, 2015

Allow sorting of folders by date owncloud/ios-legacy#318

Closed

masensio mentioned this pull request Mar 17, 2015

Add "sort by size" #895

Closed

1 task

tobiasKaminsky deleted the sortingFiles branch August 26, 2015 06:46

David177 mentioned this pull request May 4, 2016

add "sort by name descending" (Z-A) option #1656

Closed

muzafferbugra mentioned this pull request Mar 12, 2017

sort by name descending" (Z-A) option emreatci/android#13

Open

Conversation

tobiasKaminsky commented Sep 14, 2014

Uh oh!

davivel commented Sep 15, 2014

Uh oh!

tobiasKaminsky commented Sep 15, 2014

Uh oh!

jancborchardt commented Sep 15, 2014

Uh oh!

jancborchardt commented Sep 15, 2014

Uh oh!

tobiasKaminsky commented Sep 15, 2014

Uh oh!

jancborchardt commented Sep 15, 2014

Uh oh!

jancborchardt commented Sep 15, 2014

Uh oh!

jancborchardt commented Sep 15, 2014

Uh oh!

jancborchardt commented Sep 15, 2014

Uh oh!

tobiasKaminsky commented Sep 15, 2014

Uh oh!

MTRichards commented Sep 15, 2014

Uh oh!

MTRichards commented Sep 15, 2014

Uh oh!

tobiasKaminsky commented Sep 15, 2014

Uh oh!

jancborchardt commented Sep 15, 2014

Uh oh!

tobiasKaminsky commented Sep 15, 2014

Uh oh!

davivel commented Sep 17, 2014

Uh oh!

jancborchardt commented Sep 17, 2014

Uh oh!

davivel commented Sep 17, 2014

Uh oh!

tobiasKaminsky commented Sep 18, 2014

Uh oh!

tobiasKaminsky commented Sep 18, 2014

Uh oh!

DeepDiver1975 commented Sep 18, 2014

Uh oh!

DeepDiver1975 commented Sep 18, 2014

Uh oh!

davivel commented Sep 18, 2014

Uh oh!

davivel commented Sep 18, 2014

Uh oh!

jancborchardt commented Oct 10, 2014

Uh oh!

tobiasKaminsky commented Oct 11, 2014

Uh oh!

jancborchardt commented Oct 13, 2014

Uh oh!

davivel commented Oct 14, 2014

Uh oh!

davivel Oct 17, 2014

Choose a reason for hiding this comment

Uh oh!

tobiasKaminsky Oct 17, 2014

Choose a reason for hiding this comment

Uh oh!

davivel commented Oct 17, 2014

Uh oh!

tobiasKaminsky commented Oct 17, 2014

Uh oh!

davivel Oct 20, 2014

Choose a reason for hiding this comment

Uh oh!

tobiasKaminsky Oct 20, 2014

Choose a reason for hiding this comment

Uh oh!

davivel commented Oct 21, 2014

Uh oh!

davivel commented Oct 24, 2014

Uh oh!

tobiasKaminsky commented May 4, 2016