Skip to content

Add "select all" option to photo (or other) upload screen#669

Merged
grecep merged 2 commits intoowncloud:developfrom
grecep:master
Oct 29, 2014
Merged

Add "select all" option to photo (or other) upload screen#669
grecep merged 2 commits intoowncloud:developfrom
grecep:master

Conversation

@grecep
Copy link
Copy Markdown
Contributor

@grecep grecep commented Oct 20, 2014

As discussed and requested in #634

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not doing anything when file is a directory, this check is not necessary.

@davivel
Copy link
Copy Markdown
Contributor

davivel commented Oct 21, 2014

Hi @grecep . I think this is your first contribution, isn't it? Before we can accept the PR we need you sign the contributor agreement in https://owncloud.org/contribute/agreement/ and send it to @karlitschek .

@jancborchardt
Copy link
Copy Markdown
Member

@grecep you’re most welcome in our IRC channel #owncloud-android (on freenode)! :)

grecep added a commit that referenced this pull request Oct 29, 2014
Add "select all" option to photo (or other) upload screen
@grecep grecep merged commit fd7a940 into owncloud:develop Oct 29, 2014
@LukasReschke
Copy link
Copy Markdown
Member

@davivel Did this pass QA?

@davivel
Copy link
Copy Markdown
Contributor

davivel commented Nov 21, 2014

What? @grecep, developers cannot merge their own contributions without review and QA.

@grecep
Copy link
Copy Markdown
Contributor Author

grecep commented Nov 21, 2014

Sorry for troubles, I made a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants