[Linux] trailing newline or carriage in filename are neither rejected nor handled correctly

[jnweiger]

owncloud-client 2.5.2rc1 on Linux mint happily uploads files with trailing newline 0x0a or carriage return 0x0d to the owncloud server. The server web ui handles them, and replaces them with an _ when requesting a download via web.
owncloud-client 2.5.2rc1 on windows fails with error messages.
A trailing carriage return causes "Access denied" (very misleading)
A trailing newline causes "The filename, directory name, or volume label syntax is incorrect"

[ogoffart]

You seem to describe a problem on the server rather than a problem on the client.

Btw, When I tried with the demo server, i get the error File name contains at least one invalid character which seems correct.

[ckamm]

I can reproduce the problem, "foo\n" uploads successfully (created with touch $'foo\n' in zsh). We could add \x00-\x1F to our invalid filename regex? Or just \R? Anything in the unicode control characters category? Opinions? @jnweiger @ogoffart @guruz

The current pattern is [\\:?*"<>|]

[guruz]

I'd say "Anything in the unicode control characters category" but I'm not an expert.

[ckamm]

We have two options here:

1. consider this invalid early, not even uploading these files
2. consider this invalid filenames for downloading to Windows systems

We currently do a mix of both. The pattern I mentioned above is for 1) but there are also some 2)-style filters (like windows reserved words).

For control characters I'd suggest 1) since they also not great to have on the server.