Improve folder selection in wizards#5638
Merged
ckamm merged 2 commits intoowncloud:masterfrom Mar 21, 2017
Merged
Conversation
Contributor
|
Note to self; check what happens with the finder integration that creates a sync folder shortcut in the left bar when the default folder name was used. |
Contributor
Contributor
Author
|
@SamuAlfageme That is indeed occasionally confusing users, but would need a significant account creation wizard redesign. Currently the ability to only sync a remote subfolder is not being exposed in the folder setup part of the account creation wizard. It'd probably be okay to expand and complicate the "Choose what to sync" part as long as we keep the easy "Sync everything" option in place. |
ogoffart
reviewed
Mar 21, 2017
Contributor
There was a problem hiding this comment.
if ok is not used, maybe we should leave it out.
Contributor
|
👍 |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily address #5597: Don't propose existing folders as sync folders in wizards to not cause accidents.