OAuth: Wizard page

[ogoffart]

Show smething sensible if the user click on the owncloud icon, and handle errors

Issues: #5813 and #5811

[ckamm]

Some minor comments. At this point I'd really like to try it out. What kind of setup changes do I need?

[ckamm]

Why? Isn't it okay to stay on the HttpCreds page if auth fails?

Also, isn't this unrelated to OAuth?

[ogoffart]

Oops, it was supposed to be the OAuth page of course. Well spotted.

(This normally should not never happen because if we have a oauth connection, it should normaly work always. )

[ckamm]

We no longer use Q_DECL_OVERRIDE?

[ogoffart]

AFAIK we dropped centos 6 whi had that old compiler. And even then we had upgraded to a more recent one.

[ckamm]

Is there the need to re-enable the back button on other pages? In case we add further pages, or OAuth isn't supported and we fall back to http creds?

[ogoffart]

1. The QWizard already reset the enabled property on the buttons each time the page change.
2. Since the next page is the final one and its not possible to go back, either, we are fine.

[ogoffart]

@ckamm In order to try it out, you simply need to checkout the oauth2 apps in your apps directory
https://github.com/owncloud/oauth2/ and enable it from the apps setting page.

Normally, since owncloud/oauth2#38 , the client app should automatically be registered, but this did not happen to me or @SamuAlfageme . So I had to manually add the client in the server DB:

INSERT INTO oc_oauth2_clients (identifier, secret, redirect_uri, name) VALUES('xdXOt13JKxym1B1QcEncf2XDkLAexMBFwiT9j6EfhhHFJhs2KM9jbjTmf8JBXE69', 'UBntmLjC2yYCeHwsyj73Uwo9TAaecAetRwMw0xYcvNL9yRdLSUi0hUAHfvCHFeFh', 'http://localhost:*', 'Desktop Client');

Alternatively, you can also register a new client from the admin interface, and change the values in theme.cpp

[ckamm]

I'll also do a test run later.

[ckamm]

@ogoffart From testing:

• Works!
• I also had to manually insert the "Desktop Client" oauth client. The table was empty initially.
• "Login Successfull" -> one too many "l" (will fix)
• I had one http and one oauth account set up for the same user+server, that lead to problems. (same keychain entry, probably) We might want to use some unique identifier to disambiguate. (will make ticket)