Blacklist: Don't let errors become warnings #5516#5865
Merged
Conversation
Before, blacklisted errors were set to FileIgnored status and hence displayed as warnings. Now, they have their own BlacklistedError category which allows them to appear as errors in the issues list and in the shell integration icons.
Contributor
|
Code looks 👍 |
guruz
approved these changes
Jul 3, 2017
Contributor
Author
|
@guruz CI is good, can me merged? |
Contributor
|
I didn't see the Ci go good on this yet, i thought it should have been retriggered but wasn't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, blacklisted errors were set to FileIgnored status and hence
displayed as warnings. Now, they have their own BlacklistedError
category which allows them to appear as errors in the issues list and in
the shell integration icons.