Update server url in case of permanent redirection #5972#6009
Merged
Conversation
ckamm
force-pushed
the
permanent-redirect
branch
from
cf455a2 to
83ff456
Compare
This was referenced Sep 11, 2017
ckamm
force-pushed
the
permanent-redirect
branch
from
8cd14b4 to
83ff456
Compare
Contributor
Author
|
Depends on #6007 (first commit) |
Contributor
|
👍 but dependent commit needs fixes for the build |
* Move it to networkjobs * Minor adjustments to its logic * Fixes redirect handling for oauth/basic http auth check #6003
This is the first time the account url may update outside of account setup. Summary of redirection handling: 1. During account setup (wizard) - status.php gets permanently redirected -> adjust url - authed PROPFIND gets *any* redirection -> adjust url 2. During connectivity ping (ConnectionValidator) - status.php gets permanently redirected -> adjust url (new!) All other redirections should be followed transparently and don't update the account url in the settings.
ckamm
force-pushed
the
permanent-redirect
branch
from
83ff456 to
0aa7763
Compare
guruz
approved these changes
Sep 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first time the account url may update outside of
account setup.
Summary of redirection handling:
All other redirections should be followed transparently and
don't update the account url in the settings.
See #5972