Skip to content

Issues: Speed up insertion and add hard upper limit#6280

Merged
ckamm merged 1 commit into
2.4from
issues-disable-sort-on-insert
Jan 5, 2018
Merged

Issues: Speed up insertion and add hard upper limit#6280
ckamm merged 1 commit into
2.4from
issues-disable-sort-on-insert

Conversation

@ckamm
Copy link
Copy Markdown
Contributor

@ckamm ckamm commented Jan 4, 2018

Since sorting was enabled permanenty the list would be resorted with
each inserted issue. When inserting thousands of ignored files that
would make the whole ui freeze up.

Instead, sorting is disabled for inserts now and is reenabled after some
time has passed. That way users usually see the sorted view without the
lockups. Also, there's now a maximum of 50k issue entries.

See #6272

Since sorting was enabled permanenty the list would be resorted with
each inserted issue. When inserting thousands of ignored files that
would make the whole ui freeze up.

Instead, sorting is disabled for inserts now and is reenabled after some
time has passed. That way users usually see the sorted view without the
lockups. Also, there's now a maximum of 50k issue entries.
@ckamm ckamm added this to the 2.4.1 milestone Jan 4, 2018
@ckamm ckamm self-assigned this Jan 4, 2018
@ckamm ckamm requested a review from ogoffart January 4, 2018 12:56
Copy link
Copy Markdown
Contributor

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ckamm ckamm merged commit 7aa9af0 into 2.4 Jan 5, 2018
@ckamm ckamm deleted the issues-disable-sort-on-insert branch January 5, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants