Marking two files with the same name as "Favorites" ends up listing three on the favorites page

[jnfrmarks]

Steps to reproduce

1. Install two 8.1 servers
2. On server 1 upload a bunch of files
3. On server 2 create a user
4. On server 2 enable external storage
5. On server 2 configure external webdav mounts to point to server 1
6. On server 2 log in as user
7. On server 2 upload a file with the same name as a file on the webdav mount
8. On server 2 mark the uploaded file as a favorite
9. On server 2 mark the file with the same name on the external mount as a favorite
10. Click on favorites link

Expected behaviour

Should see two favorites

Actual behaviour

There are three favorites

Server log file

{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => uid=abagail_kuhic,ou=people,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: uid=abagail_kuhic,ou=people,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => uid=abagail_kuhic,ou=people,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => primaryGroupID\n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Requested attribute primarygroupid not found for uid=abagail_kuhic,ou=people,dc=owncloudqa,dc=com","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => uid=abagail_kuhic,ou=people,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => memberOf\n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=aggregate-ubiquitous-schemas,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=aggregate-ubiquitous-schemas,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=architect-intuitive-infrastructures,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=architect-intuitive-infrastructures,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=architect-dot-com-niches,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=architect-dot-com-niches,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=brand-world-class-deliverables,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=brand-world-class-deliverables,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=benchmark-bricks-and-clicks-infomediaries,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=benchmark-bricks-and-clicks-infomediaries,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=aggregate-24x7-users,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=aggregate-24x7-users,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=brand-transparent-e-commerce,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=brand-transparent-e-commerce,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=deliver-bricks-and-clicks-e-business,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=deliver-bricks-and-clicks-e-business,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=benchmark-proactive-web-readiness,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=benchmark-proactive-web-readiness,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"initializing paged search for  Filter objectClass=* base Array\n(\n    [0] => cn=benchmark-frictionless-applications,ou=groups,dc=owncloudqa,dc=com\n)\n attr Array\n(\n    [0] => \n)\n limit 500 offset 0","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"Ready for a paged search","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}
{"reqId":"ltHVv1gpNiu+3iKVZ0mC","remoteAddr":"172.18.0.165","app":"user_ldap","message":"readAttribute: cn=benchmark-frictionless-applications,ou=groups,dc=owncloudqa,dc=com found","level":0,"time":"2015-06-16T10:16:04+00:00","method":"GET","url":"\/owncloud\/index.php\/apps\/files\/api\/v1\/tags\/_%24!%3CFavorite%3E!%24_\/files"}

App configuration

Enabled:
 - activity: 2.0.0
 - admin_audit: 0.6
 - encryption: 1.0.0
 - enterprise_key: 0.1.0
 - files: 1.1.9
 - files_external: 0.2.3
 - files_locking:
 - files_pdfviewer: 0.7
 - files_sharing: 0.6.1
 - files_sharing_log: 0.5
 - files_texteditor: 0.4
 - files_trashbin: 0.6.2
 - files_versions: 1.0.5
 - files_videoviewer: 0.1.3
 - gallery: 0.6.0
 - provisioning_api: 0.2
 - templateeditor: 0.1
 - updater: 0.4
 - user_ldap: 0.6.0
 - windows_network_drive: 0.1.1
Disabled:
 - external
 - files_antivirus
 - files_drop
 - files_ldap_home
 - firewall
 - firstrunwizard
 - objectstore
 - sharepoint
 - user_external
 - user_shibboleth
 - user_webdavauth

Server 1 Host info:

Ubuntu 14.04
PHP 5.5.9

Server configuration:

ownCloud Enterprise Edition 8.1 beta 2 (daily) Build:2015-06-15T03:10:33+00:00 fe9b28a

[jnfrmarks]

I validated that only two names show up (as expected) when both files are local

[jnfrmarks]

I figured out what's going on here.

I have two webdav mounts to the same folder. One is over http, the other over https. In the case of the webDAV mount, I marked the file as a favorite from the http mount. It's showing up 3 times because technically, it's there three times.. I think the only question I have is if this is the correct behavior. I'm torn

[PVince81]

Hmm, need to find out whether the two webdav mounts are using the same oc_storage entry or two different ones. It is likely that they are using the same storage entry in the database, so the files would have the same file id.

Whenever the favorites list is displayed, it will show you favorites from each mount point. I think this is expected.

The problem here is more the fact that you are able to mount the same mount point twice and that it gets "merged" into the same storage entry internally, which could cause side-effects.