ChunkingNG: Uploading existing file re-creates fileID

[guruz]

The FileID returned by the final MOVE is not the same as the existing's file FileID.
Normaly FileID should not change when a file is modified.

https://github.com/owncloud/client/wiki/Etags-and-file-ids "File IDs never change for the lifetime of a file."

Note that this is only a theorical issue. The client does not have any problem with changing fileids and the sync algorithm will not be impacted by this bug.

01-20 19:02:26:711 528416 OCC::PropagateUploadFileNG::slotMoveJobFinished: WARN: File ID changed! "00011435ocdvdsg4rwx8" "00013624ocdvdsg4rwx8"

[PVince81]

@SergioBertolinSG we need integration tests for new chunking

[SergioBertolinSG]

@PVince81 there are some tests about it already: https://github.com/owncloud/core/blob/master/build/integration/features/webdav-related.feature#L374

[PVince81]

@SergioBertolinSG please add one to cover this one case where the FileID must not change on overwrite. (also see if we have this test for dav v1 and if not, add it too)

[PVince81]

Any update ?

[SergioBertolinSG]

Added here: #27508

it is failing because the fileID changes.

[PVince81]

Analysis here: #27508 (comment).

New DAV endpoint doesn't reuse custom ObjectTree so "move" becomes a copy+delete which will cause fileid change.

[PVince81]

and fileid change is bad because it causes metadata loss, bye bye shares, favorite, tags, comments, ...