Acceptance tests for sharing when the receiver has a matching file/folder

[phil-davis]

Background

Currently the sharing acceptance tests mostly use files and folders that are in the "standard" acceptance test webUI or API skeleton. e.g. user1 and user2 both have simple-folder. When user1 shares simple-folder with user2 then user2 receives a folder called simple-folder (2). So we have "accidentally" created lots of test scenarios for the case where the share receiver already has a matching file or folder name.

As part of speeding up CI, we are reducing the use of the "standard" skeleton (it takes significant time to create for every user of every scenario). Scenarios will (soon) usually result in the share receiver not already having a matching file or folder. So the (2) naming thing will not get tested much.

To Do

Create explicit test scenarios for sharing where the share receiver already has a matching file or folder name.

• share with user, receiver has a matching folder API acceptance test for creating a share with user for matching files #36451
• share with user, receiver has a matching file API test for sharing files when receiver has matching files #35455
• share with group, receiver has a matching folder API acceptance test for creating a share with user for matching files #36451
• share with group, receiver has a matching file API acceptance test for creating a share with user for matching files #36451
• share with federated, receiver has a matching folder (api test for federation sharing when the receiver has matching file/folder #35453)
• share with federated, receiver has a matching file api test for federation sharing when the receiver has matching file/folder #35453
• with and without auto-accept of shares API acceptance test for creating a share with user for matching files #36451
• shares received from multiple users with the same name file/folder acceptance test for shares received from multiple users with the same name file/folder #35457
• shares received from multiple users with the same name file/folder and different permissions (check that the different permissions work on the correct shares) acceptance test for shares received from multiple users with the same name file/folder #35457
• matching file is shared with a user before that user has logged in (what happens when the user logs in and gets a matching file in their skeleton...)
• matching folder is shared with a user before that user has logged in (what happens when the user logs in and gets a matching folder in their skeleton...) API acceptance test for creating a share with user for matching files #36451
• new user is created and added to a group. The group has shares that match the skeleton. What happens when the user logs in? acceptance test for shares received from multiple users with the same name file/folder #35457
• write more ideas for scenarios here...

[sakshamgurung]

@phil-davis I have come with following scenario lists that can be added. Please see if these are relevant:

• a user receives group shares for same name file/folder (user is member of multiple group)
• a group receives shares for same name file/folder from multiple non-member users
• a user receives share for file/folder (user decline the share first, then creates same name file/folder and at last accepts the share.)

[phil-davis]

@sakshamgurung That seems good.

The scenarios could mix up file and folder - one share is for a folder "x.y" and the other share is for a file "x.y". Brian should be able to see both received shares somehow.

Also try with different case - "x.y" and "X.Y" to make sure that there is no problem. I think that 2 shares like that should be nicely received separately.