explicit routes for files_external

[butonic]

Leftover of "Remove loadAppScriptFile #10522"

@LukasReschke @PVince81 @blizzz @th3fallen @MorrisJobke @DeepDiver1975

[scrutinizer-notifier]

A new inspection was created.

[LukasReschke]

LGTM 👍

@PVince81 What's https://github.com/owncloud/core/blob/master/apps/files_external/list.php for? - Is this still used? - If so: Does it need to be routable?

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/6837/

[PVince81]

list.php is for the list of mounts in the files app, the sidebar section "External storages".

[DeepDiver1975]

list.php is for the list of mounts in the files app, the sidebar section "External storages".

@butonic can you please add this route as well? THX

[LukasReschke]

Same would be true for files and files_sharing. - Let's put this also in this PR :-)

[butonic]

hm, I only see a http://localhost/core/index.php/apps/files/ajax/list.php?dir=%2F&sort=name&sortdirection=asc call
The list.php is accessed when http://localhost/core/index.php/apps/files/?dir=%2F&view=extstoragemounts is called

so, my guess is a list.php route is not needed?

[DeepDiver1975]

@PVince81 the externals side bar is using OCS API calls - I guess list.php is not needed any more

• drop these files?

[PVince81]

Ok got it. That list.php is a template that gets embedded when the main page loads.
It is referenced here: https://github.com/owncloud/core/blob/master/apps/files_external/appinfo/app.php#L33

It doesn't need routing as it is not meant to be included/called from outside.

[PVince81]

So please DON'T DROP the files, but drop the route, if any was added.
Else it's just a NOOP

[butonic]

files not dropped, route not added. can we merge this now pls?

[PVince81]

Ok, I'll retest this app

[PVince81]

• add/remove external storage
• add/remove certificate
• dropbox
• google drive

Where's the UI for the certificate ? Is it new ? (CC @icewind1991)

[PVince81]

Works 👍