Skip to content

Conversation

@butonic
Copy link
Member

@butonic butonic commented Sep 8, 2014

I want to be able to send deep links into the gallery, that also prefill the username if the user is not logged in, sth like http://localhost/core/index.php?redirect_url=%2Findex.php%2Fapps%2Fgallery&user=guest

The guest account has quota zero and can only access the files and pictures apps.

@LukasReschke security nightmare?
@jancborchardt usability improvement?

@scrutinizer-notifier
Copy link

A new inspection was created.

@butonic butonic added this to the 2014-sprint-03-current milestone Sep 8, 2014
@butonic butonic self-assigned this Sep 8, 2014
@LukasReschke
Copy link
Member

We already support it via POST, so I see no problem by supporting GET as well => 👍

@jancborchardt
Copy link
Member

I don’t really get it. Where would you get the link from?

@ghost
Copy link

ghost commented Sep 8, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/7152/

@karlitschek
Copy link
Contributor

same question here. Is this a feature for our demo server? or what is the real world use-case?

@butonic
Copy link
Member Author

butonic commented Sep 8, 2014

What I want is to make our family access the images of Tim Friedrich as easy as possible: sending a password protected link. Unfortunately, oc does not allow sharing a group of files with a link. Only a single file or a folder. So I created a guest account 'guest' with a quota of 0 and we now share the best pictures with that account. Over the next weeks we will be adding/sharing new images daily.

Currently, I can create a deep link to the pictures app, so that when a user logs in he will be redirected an see nice seamless thumbnails: http://localhost/core/index.php?redirect_url=%2Findex.php%2Fapps%2Fgallery

I want to make that look nicer so I created an apache rewrite rule that redirects http://localhost/baby to http://localhost/core/index.php?redirect_url=%2Findex.php%2Fapps%2Fgallery. Much better. But still has room for improvement. With this PR I can make the redirect to http://localhost/core/index.php?redirect_url=%2Findex.php%2Fapps%2Fgallery&user=guest which will now also prefill the username.

I can now send a link like http://localhost/baby along with the password so my parents only need to figure out where to put the password.

Oh and we do have a customer that uses this to send sharing emails to other accounts that then don't need to enter their username.

@butonic
Copy link
Member Author

butonic commented Sep 8, 2014

could also be used by the activity app.

@jancborchardt
Copy link
Member

The whole guest user thing is a big workaround. A way easier workaround for sharing some pictures is, well, just creating a new folder and putting all the pictures you want to share in there.

@butonic
Copy link
Member Author

butonic commented Sep 9, 2014

I don't want to duplicate the images. Anyway, think about an admin inviting new users. He might send around links with the username prefilled.

On 9. September 2014 08:27:46 MESZ, Jan-Christoph Borchardt notifications@github.com wrote:

The whole guest user thing is a big workaround. A way easier workaround
for sharing some pictures is, well, just creating a new folder and
putting all the pictures you want to share in there.


Reply to this email directly or view it on GitHub:
#10949 (comment)

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

@LukasReschke
Copy link
Member

I agree with @butonic. That said, we already have this functionality. Switching from POST to REQUEST should not be that a big deal ;-)

@butonic
Copy link
Member Author

butonic commented Sep 9, 2014

OC password reset emails could also contain a link prefilling the username.

@jancborchardt
Copy link
Member

Ok, I guess it’s useful for other usecases anyway.

@PVince81
Copy link
Contributor

PVince81 commented Sep 9, 2014

Makes sense 👍

butonic added a commit that referenced this pull request Sep 9, 2014
@butonic butonic merged commit 3d4f77c into master Sep 9, 2014
@butonic butonic deleted the allow_prefilling_login branch September 9, 2014 09:42
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants