repair search lucene before installing

[butonic]

on the way to fixing search lucene migrations, see discussion in #10205

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/7161/

[LukasReschke]

This will run on every update which seems not to be intended or at least may make things notably slower if everybody does it this way. I'd compare against the app version and make it only run once.

[butonic]

The repair step only deletes duplicate rows which should not be noticable. Try estimating

SELECT fileid FROM oc_lucene_status GROUP BY fileid HAVING count(fileid)>1

and you will see that it is quite fast. With the primary key in place in search_lucene v0.6.0 it is even faster.

[butonic]

And well, it is intended, because the migration might break when there are duplicates.

[karlitschek]

this looks good to me but can´t test at the moment. 👍 can someone else hep with properly test this?

[bantu]

Is this the correct author?

[bantu]

It's probably obvious, but anyway: This repair step is solely for the lucene application and as such this does not belong into the core repository.

[scrutinizer-notifier]

A new inspection was created.

[butonic]

@bantu all cleaned up, please see #10205 (comment) on why this has to live in core. issue to track that is in #10980

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/7182/

[bantu]

👍

[LukasReschke]

Makes sense for me 👍

[karlitschek]

@butonic Please backport

[butonic]

backport to stable7 in 463ad5a