Add clickable labels to encryption recovery radios#11337
Add clickable labels to encryption recovery radios#11337LukasReschke merged 1 commit intoowncloud:masterfrom danbartram:better_encryption_recovery_labels
Conversation
Add clickable radio button labels to the encryption recovery settings pages: * settings-admin * settings-personal Pressing on the radio button text now toggles the state of the radio button.
|
Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/ |
|
Oops, forgot about the licensing issue. This contribution is MIT licensed. |
|
The inspection completed: No new issues |
|
@schiesbn What do you think? |
|
Works 👍 |
|
👍 |
|
@owncloud-bot This is ok to test |
|
@owncloud-bot Retest this please |
|
💣 Test FAILed. 💣 |
|
@owncloud-bot Retest this please |
|
🚀 Test PASSed. 🚀 |
…labels Add clickable labels to encryption recovery radios
This is a fix for Issue: #11174.
Possible Changes
idattribute to the radio buttons, we could instead wrap the radio buttoninputtag inside of a<label>.Add clickable radio button labels to the encryption recovery settings pages:
settings-admin.phpsettings-personal.phpPressing on the radio button text now toggles the state of the radio button.
Let me know if you have any suggestions or improvements.
Edit: This contribution is MIT licensed.