Skip to content

Add clickable labels to encryption recovery radios#11337

Merged
LukasReschke merged 1 commit intoowncloud:masterfrom
danbartram:better_encryption_recovery_labels
Sep 29, 2014
Merged

Add clickable labels to encryption recovery radios#11337
LukasReschke merged 1 commit intoowncloud:masterfrom
danbartram:better_encryption_recovery_labels

Conversation

@danbartram
Copy link
Copy Markdown
Contributor

This is a fix for Issue: #11174.

Possible Changes

  • Instead of applying a new id attribute to the radio buttons, we could instead wrap the radio button input tag inside of a <label>.

Add clickable radio button labels to the encryption recovery settings pages:

  • settings-admin.php
  • settings-personal.php

Pressing on the radio button text now toggles the state of the radio button.


Let me know if you have any suggestions or improvements.

Edit: This contribution is MIT licensed.

Add clickable radio button labels to the encryption recovery settings
pages:
* settings-admin
* settings-personal

Pressing on the radio button text now toggles the state of the radio
button.
@ghost
Copy link
Copy Markdown

ghost commented Sep 27, 2014

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@danbartram
Copy link
Copy Markdown
Contributor Author

Oops, forgot about the licensing issue.

This contribution is MIT licensed.

@scrutinizer-notifier
Copy link
Copy Markdown

The inspection completed: No new issues

@karlitschek
Copy link
Copy Markdown
Contributor

@schiesbn What do you think?

@MorrisJobke
Copy link
Copy Markdown
Contributor

Works 👍

@LukasReschke
Copy link
Copy Markdown
Member

👍

@LukasReschke
Copy link
Copy Markdown
Member

@owncloud-bot This is ok to test

@LukasReschke
Copy link
Copy Markdown
Member

@owncloud-bot Retest this please

@ghost
Copy link
Copy Markdown

ghost commented Sep 29, 2014

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser/7612/

@LukasReschke
Copy link
Copy Markdown
Member

@owncloud-bot Retest this please

@ghost
Copy link
Copy Markdown

ghost commented Sep 29, 2014

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser/7621/

LukasReschke added a commit that referenced this pull request Sep 29, 2014
…labels

Add clickable labels to encryption recovery radios
@LukasReschke LukasReschke merged commit 659b9fc into owncloud:master Sep 29, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants