Close the session for preview generation#11352
Merged
LukasReschke merged 1 commit intomasterfrom Sep 29, 2014
Merged
Conversation
Without closing the session every preview image generation is locking the session which makes the webinterface unresponsive.
Member
|
nice catch 👍
|
Member
Author
|
@karlitschek We should backport this... I think... |
|
The inspection completed: No new issues |
Contributor
|
👍 |
Contributor
|
indeed very cool. 👍 Please backport. This will make a lot of users happy who complained about the preview performance. :-) |
|
🚀 Test PASSed. 🚀 |
LukasReschke
added a commit
that referenced
this pull request
Sep 29, 2014
Close the session for preview generation
Member
Author
|
stable7: 7eb0d68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without closing the session every preview image generation is locking the session which makes the webinterface unresponsive.