we also encrypt/decrypt files in the versions folder

[schiessle]

we also encrypt/decrypt files in the versions folder for previews and if encryption is enabled/disabled.

This fixes the preview creation for versions if encryption is enabled.

[MorrisJobke]

What about the trashbin?

[schiessle]

@MorrisJobke For the trash bin we don't provide previews at the moment. For versions it is relatively easy because only the encrypted file is stored at a different location (/data/user/files_versions) but the keys are all at the same place as for the current file because all of them use the same keys.
For the trashbin not only the file is in /data/user/files_trashbin but also the keys. To make it work for the trash bin we would need to handle a lot of special cases. Maybe this will come in the future.

[LukasReschke]

Well, why not 👍

[LukasReschke]

(requires a documentation update after merging)

[schiessle]

There should be no documentation update needed, This is just a bug fix, we already encrypted versions before.

[schiessle]

The jenkins fail is unrelated... Can we have a second reviewer for this small fix? @MorrisJobke @PVince81 Thanks!

[PVince81]

Can you add a unit test for this ?
Maybe unit-testing the function isEncryptedPath() would be nice if there isn't one already.

[schiessle]

@PVince81 unit tests added

[DeepDiver1975]

@owncloud-bot retest this please

[scrutinizer-notifier]

The inspection completed: 6 new issues, 7 updated code elements

[PVince81]

Before the fix: text preview appears encrypted in versions dropdown
After the fix: text preview appears correctly in versions dropdown

👍

[ghost]

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng/110/

[MorrisJobke]

@schiesbn Backport?

[schiessle]

yes, I will backport it

[schiessle]

stable7: 3039837

[karlitschek]

Thanks.
Would be great to wait for an approval from me before backporting. :-)