[encryption] some visual improvements#11453
Merged
MorrisJobke merged 4 commits intomasterfrom Oct 8, 2014
Merged
Conversation
added 4 commits
October 7, 2014 12:02
|
The inspection completed: 5 new issues, 2 updated code elements |
|
🚀 Test PASSed. 🚀 |
Contributor
Author
|
Some small visual improvements, @ser72 already tested it here: #11393 (comment) Who wants to be the second reviewer? Maybe @PVince81 @MorrisJobke @th3fallen ? Thanks! |
Contributor
|
I'm just reviewing :) |
Contributor
Author
|
Great, Thanks a lot! |
Contributor
|
Works 👍 |
MorrisJobke
added a commit
that referenced
this pull request
Oct 8, 2014
[encryption] some visual improvements
Contributor
|
@schiesbn @karlitschek Backport? |
Contributor
Author
|
Looking at the initial issue I assume yes... I will take care of it. |
Contributor
Author
|
stable7: a045f8c...a766f5b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved visual feedback as described here #11393
Additional improved feedback if the user enabled/disables the recovery key. Now it uses the same read/green tags like everywhere else.