Migrate new app settings to AppFramework

[LukasReschke]

Let's migrate those two new files. - Code logic is not touched, this is only for the sake of preventing more ugly ajax/* files having added.

@DeepDiver1975 As discussed.

[LukasReschke]

(Writing sane unit tests for this seems like a nearly impossible task considered the fact that OC_App is completely static)

[scrutinizer-notifier]

The inspection completed: 10 new issues, 6 updated code elements

[ghost]

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/327/
🚀 Test PASSed. 🚀

[icewind1991]

👍 tested

[PVince81]

Your tabbing is going too far!

[LukasReschke]

Mhm - works for me locally, according to our coding guidelines:

Use tabs to indent
A tab is 4 spaces wide

And then it matches:

[PVince81]

Code looks good 👍

How about adding unit tests now that this is nicely encapsulated ? 😈

[PVince81]

Hmmm, seems that \OC_App::listAllApps(true); isn't... Can OC_App be injected as well ?
Then unit tests could be written that mock it.

[LukasReschke]

Hmmm, seems that \OC_App::listAllApps(true); isn't... Can OC_App be injected as well ?
Then unit tests could be written that mock it.

That would require some refactoring on OC_App as far I can see, let's schedule this for later.