Merged
Conversation
This function might also be called before ownCloud is setup which results in a PHP fatal error. We therefore should gracefully catch errors in there.
Contributor
|
Setup works for me 👍 |
Contributor
|
👍 fixes the installation |
|
The inspection completed: No new issues |
Contributor
|
Since this would break the setup on some envs, upgrade to gold |
|
🚀 Test PASSed. 🚀 |
PVince81
pushed a commit
that referenced
this pull request
Oct 16, 2014
…ndition Add a try catch block
Member
Author
|
Stable7: f2dadc7 |
Contributor
|
thanks lukas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function might also be called before ownCloud is setup which results in a PHP fatal error. We therefore should gracefully catch errors in there.
@butonic @PVince81 As discussed.
@karlitschek Regression due to a race condition - I'll backport this to stable7 because the concerning commit is in there since today and breaks the setup.