Skip to content

fix target creation for public links #11691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 2 commits into from
Oct 22, 2014
Merged

fix target creation for public links #11691

PVince81 merged 2 commits into from
Oct 22, 2014

Conversation

@schiessle
Copy link
Contributor

@schiessle schiessle commented Oct 21, 2014

fix #11645

PR against stable7 because master is in transition to a different implementation.

cc @PVince81

PVince81
PVince81 reviewed Oct 21, 2014
View reviewed changes
apps/files_sharing/public.php
Copy link
Contributor

@PVince81 PVince81 Oct 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that simply an additional safety or is it mandatory for the original fix ? (just for information)

Copy link
Contributor Author

@schiessle schiessle Oct 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is a additional fix how the path to the file is constructed. Without the patch you will not be able to download a public link share of a single file if it was re-shared before.

@scrutinizer-notifier
Copy link

scrutinizer-notifier commented Oct 21, 2014

The inspection completed: No new issues

@PVince81
Copy link
Contributor

PVince81 commented Oct 21, 2014

The code looks good, going to test this soon.

@PVince81
Copy link
Contributor

PVince81 commented Oct 21, 2014

Works correctly with external storage app enabled:

  • no more weird folders inside data
  • link password can be set

👍

@PVince81
Copy link
Contributor

PVince81 commented Oct 21, 2014

Confirmed working by @sbelov1 here #11645 (comment)
Counting as 👍

@PVince81
Copy link
Contributor

PVince81 commented Oct 22, 2014

@owncloud-bot retest this please

@ghost
Copy link

ghost commented Oct 22, 2014

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/864/
🚀 Test PASSed. 🚀

PVince81 pushed a commit that referenced this pull request Oct 22, 2014
Merge pull request #11691 from owncloud/fix_pub_link_creation
5624968 
fix target creation for public links
@PVince81 PVince81 merged commit 5624968 into stable7 Oct 22, 2014
@PVince81 PVince81 deleted the fix_pub_link_creation branch October 22, 2014 09:06
@PVince81
Copy link
Contributor

PVince81 commented Oct 22, 2014

@karlitschek backporting this to stable7

@PVince81
Copy link
Contributor

PVince81 commented Oct 22, 2014

Ah wait, this is already stable7.
Will forward port to master then.

@PVince81
Copy link
Contributor

PVince81 commented Oct 22, 2014

Can't forward port easily due to conlflicts, can you take care of this @schiesbn ?
Thanks.

@schiessle
Copy link
Contributor Author

schiessle commented Oct 22, 2014

I will take care of it

@schiessle
Copy link
Contributor Author

schiessle commented Oct 22, 2014

Selective forward port to master: b7718bc
The other commit is not relevant for master

@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schiessle @scrutinizer-notifier @PVince81