Conversation
|
👍 |
|
The inspection completed: No new issues |
|
🚀 Test PASSed. 🚀 |
|
@oparoz @danbartram Easy to review ;) |
|
Is there some background info somewhere as to what this fixes? ;) |
|
Well, this fixes nothing except that the code will actually never get executed. When an exception is thrown the code after that will not get executed. Therefore the return false is just unnecessary and confusing for developers. |
|
@oparoz It was spotted by an static code analyzer. And if you look at the code it totally makes sense to drop the return statement as it is useless. |
|
👍 |
Remove unreachable statement
|
Thanks guys for letting me know what to look for. It was indeed obvious. |
|
Thanks guys. :) |
@MorrisJobke @schiesbn