Skip to content

Remove unreachable statement#11751

Merged
LukasReschke merged 1 commit intomasterfrom
fix-unreachable-statement
Oct 23, 2014
Merged

Remove unreachable statement#11751
LukasReschke merged 1 commit intomasterfrom
fix-unreachable-statement

Conversation

@LukasReschke
Copy link
Copy Markdown
Member

@MorrisJobke @schiesbn

@MorrisJobke
Copy link
Copy Markdown
Contributor

👍

@scrutinizer-notifier
Copy link
Copy Markdown

The inspection completed: No new issues

@ghost
Copy link
Copy Markdown

ghost commented Oct 23, 2014

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/1108/
🚀 Test PASSed. 🚀

@MorrisJobke
Copy link
Copy Markdown
Contributor

@oparoz @danbartram Easy to review ;)

@oparoz
Copy link
Copy Markdown
Contributor

oparoz commented Oct 23, 2014

Is there some background info somewhere as to what this fixes? ;)

@LukasReschke
Copy link
Copy Markdown
Member Author

Well, this fixes nothing except that the code will actually never get executed. When an exception is thrown the code after that will not get executed.

Therefore the return false is just unnecessary and confusing for developers.

@MorrisJobke
Copy link
Copy Markdown
Contributor

@oparoz It was spotted by an static code analyzer. And if you look at the code it totally makes sense to drop the return statement as it is useless.

@danbartram
Copy link
Copy Markdown
Contributor

👍

LukasReschke added a commit that referenced this pull request Oct 23, 2014
@LukasReschke LukasReschke merged commit 46dd59f into master Oct 23, 2014
@LukasReschke LukasReschke deleted the fix-unreachable-statement branch October 23, 2014 22:18
@oparoz
Copy link
Copy Markdown
Contributor

oparoz commented Oct 23, 2014

Thanks guys for letting me know what to look for. It was indeed obvious.

@MorrisJobke
Copy link
Copy Markdown
Contributor

Thanks guys. :)

@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants