Merged
Conversation
lib/private/vobject.php
Outdated
Contributor
There was a problem hiding this comment.
add spaces, once you're on it.
LukasReschke
force-pushed
the
use-function-outside-of-loop
branch
from
2ff7eb7 to
52d8765
Compare
Member
|
for me it's anyhow questionable why for loops are used - generally speaking. never the less 👍 |
LukasReschke
force-pushed
the
use-function-outside-of-loop
branch
from
52d8765 to
fb4b030
Compare
Contributor
|
👍 |
Otherwise the function is executed n times which is a lot of overhead
LukasReschke
force-pushed
the
use-function-outside-of-loop
branch
from
fb4b030 to
d060180
Compare
|
The inspection completed: No new issues |
|
🚀 Test PASSed. 🚀 |
LukasReschke
added a commit
that referenced
this pull request
Oct 24, 2014
Use function outside of loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the function is executed n times which is a lot of overhead.
@MorrisJobke