Conversation
Member
Author
|
We have to add a new function here because the name is also used in other contexts where it is escaped. |
|
The inspection completed: 2 updated code elements |
|
🚀 Test PASSed. 🚀 |
Member
|
@schiesbn can you do a technical review of this? I can't review the PHP code. |
Contributor
|
@jancborchardt If you're okay with adding the HTML to the brand: I'm okay with the way it is done. Also the PHP part looks fine 👍 |
Member
|
👍 |
Member
|
backporting .... |
Member
|
stable7 8d87a2c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jancborchardt @karlitschek