fix shortcuts - underline instead of camelCase#11940
Merged
DeepDiver1975 merged 1 commit intomasterfrom Nov 4, 2014
Merged
Conversation
Member
👎 |
Contributor
|
@LukasReschke in terms of template functions: theyre in general all lowercase and separated with an underscore, see https://github.com/owncloud/core/blob/master/lib/private/template/functions.php I'd 👍 to stay consistent with the functions we currently have. This is basically the only place where we use functions so i think its fine |
Member
|
Well, then 👍 |
|
The inspection completed: No new issues |
Member
|
🙈 🙉 🙊 |
DeepDiver1975
added a commit
that referenced
this pull request
Nov 4, 2014
fix shortcuts - underline instead of camelCase
|
🚀 Test PASSed. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @DeepDiver1975 @Raydiation @LukasReschke