Only set the default expiration date on share creation#22192
Only set the default expiration date on share creation#22192DeepDiver1975 merged 3 commits intomasterfrom
Conversation
|
Tested and works 👍 |
|
Code also looks good :) |
There was a problem hiding this comment.
Seems like a violation of the PHPDoc as that seems to document only string?
There was a problem hiding this comment.
mmmm suggestions for an exception to use here then?
There was a problem hiding this comment.
Ok fixed... just added | null in the phpdoc...
There was a problem hiding this comment.
It always feels bad and it caused a lot of trouble in the past. Can't we handle this via exception?
There was a problem hiding this comment.
sure... which one do you suggest...
There was a problem hiding this comment.
Something like AttributeNotAvailableException ? cc @DeepDiver1975
There was a problem hiding this comment.
mmm we already have such a zoo of exceptions. i'd rather not have yet another custom one here... The exception name is fine from my POV but for something such generic it shouldnot be in specifc to the share...
There was a problem hiding this comment.
Maybe UnexceptedValueException? (http://php.net/manual/en/class.unexpectedvalueexception.php)
There was a problem hiding this comment.
Maybe UnexceptedValueException?
Sounds good.
|
Tested and works 👍 |
|
@rullzer Please check out the failing integration tests ;) |
|
Should be fixed now... |
There was a problem hiding this comment.
if either ? This english not is :yoda:
There was a problem hiding this comment.
I have no idea what I wanted to write there...
Fixes #19685 The default expiration date should only be set when we create a new share. So if a share is created and the expiration date is unset. And after that the password is updated the expiration date should remain unset.
|
Tested and still works 👍 |
|
👍 |
Only set the default expiration date on share creation
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
6 participants
Fixes #19685
The default expiration date should only be set when we create a new
share. So if a share is created and the expiration date is unset. And
after that the password is updated the expiration date should remain
unset.
CC: @MorrisJobke @PVince81 @nickvergessen @schiesbn