[stable9] Make getShareFolder use given view instead of static FS #25150

Merged
merged 1 commit into from Jun 20, 2016

Projects

None yet

3 participants

@PVince81
Collaborator

Workaround that makes #24423 work again.

However in that specific scenario the skeleton files won't be copied.

The code change itself should be fine as it makes use of a real view instance.

@icewind1991 @rullzer @butonic

@PVince81 PVince81 Make getShareFolder use given view instead of static FS
6b6997b
@PVince81 PVince81 added this to the 9.1-current milestone Jun 16, 2016
@mention-bot

By analyzing the blame information on this pull request, we identified @schiessle, @icewind1991 and @LukasReschke to be potential reviewers

@PVince81 PVince81 changed the title from Make getShareFolder use given view instead of static FS to [stable9] Make getShareFolder use given view instead of static FS Jun 16, 2016
@PVince81
Collaborator
  • forward port to master/9.1
@PVince81
Collaborator

Setting as critical because without this some LDAP environments that have the "mail" attribute set cause new users to not be able to login at all.

Needs review @icewind1991 @georgehrke @owncloud/sharing @DeepDiver1975

@PVince81
Collaborator

The fix was tested in the original issue and confirmed solving the "cannot login part".
The remaining issue is that skeleton files aren't copied but that's less critical.

See #24423 (comment)

@PVince81
Collaborator

master/9.1 PR is here #25161

@PVince81
Collaborator

Review please @icewind1991 @georgehrke

Or should I count the successful test reports from the original ticket as thumbs up ?

@DeepDiver1975
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 0129437 into stable9 Jun 20, 2016

20 checks passed

cla-bot-core Build #4871 succeeded in 1 min 9 sec
Details
continuous-integration/php-5.4 Build #5031 succeeded in 8 min 2 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #62910 succeeded in 52 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #31819 succeeded in 31 min
Details
core-ci-linux/database=oci,label=SLAVE Build #31819 succeeded in 1 hr 6 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #31819 succeeded in 29 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #31819 succeeded in 8 min 16 sec
Details
ocs-api-integration-tests-ci Build #11664 succeeded in 9 min 19 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11173 succeeded in 2 min 24 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11173 succeeded in 10 min
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11173 succeeded in 13 min
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #40143 succeeded in 8 min 17 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15490 succeeded in 8 min 59 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15490 succeeded in 45 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15490 succeeded in 19 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15490 succeeded in 55 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15490 succeeded in 41 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15490 succeeded in 14 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15490 succeeded in 24 min
Details
@DeepDiver1975 DeepDiver1975 deleted the stable9-fixgetsharefolder branch Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment