Skip to content

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Feb 16, 2017

Description

Do not rely on the session when reading the version information from versino.php

Related Issue

refs #26663

Motivation and Context

K.I.S.S

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0 milestone Feb 16, 2017
@PVince81
Copy link
Contributor

I can't reproduce #26663 but I can say that the regular workflow works (+ tested update)

👍

@DeepDiver1975 DeepDiver1975 merged commit 8addc1c into master Feb 16, 2017
@DeepDiver1975 DeepDiver1975 deleted the byebye-version-in-session branch February 16, 2017 17:32
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants