Don't store version number in the session #27173

Merged
merged 1 commit into from Feb 16, 2017

Projects

None yet

2 participants

@DeepDiver1975
Member
DeepDiver1975 commented Feb 16, 2017 edited

Description

Do not rely on the session when reading the version information from versino.php

Related Issue

refs #26663

Motivation and Context

K.I.S.S

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@DeepDiver1975 DeepDiver1975 Don't store version number in the session - refs #26663
23dde75
@DeepDiver1975 DeepDiver1975 added this to the 10.0 milestone Feb 16, 2017
@PVince81
Collaborator

I can't reproduce #26663 but I can say that the regular workflow works (+ tested update)

👍

@DeepDiver1975 DeepDiver1975 merged commit 8addc1c into master Feb 16, 2017

3 of 4 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
Scrutinizer 18 new issues, 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the byebye-version-in-session branch Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment