Skip to content

trigger event on input autofill#27273

Merged
PVince81 merged 1 commit intomasterfrom
fh_input_autofill
Mar 7, 2017
Merged

trigger event on input autofill#27273
PVince81 merged 1 commit intomasterfrom
fh_input_autofill

Conversation

@lordelix
Copy link
Contributor

Description

Trigger a js event on choosing autofill in input fields

Related Issue

#27096

How Has This Been Tested?

Tested in FF 51 only (so far)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@felixheidecke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 and @vgezer to be potential reviewers.

@davitol
Copy link
Contributor

davitol commented Feb 28, 2017

  • Firefox 51 for OSX
  • Safari 9.1.2
  • Chrome 56

@felixheidecke

👍 From my POV to merge this PR, but:

  • With all browser, cleaning the textbox, the message says email saved ( I feel OK about it)
  • Using Safari as browser, using one of the mails saved, the gauge does not work properly, but the mail gets saved.

mailbeh

@PVince81
Copy link
Contributor

PVince81 commented Mar 1, 2017

This will clash with #27277 where a Save button was added because of sending email confirmation.

@PVince81
Copy link
Contributor

PVince81 commented Mar 1, 2017

but as this is usable for other fields => 👍

@lordelix
Copy link
Contributor Author

lordelix commented Mar 1, 2017

This will clash with #27277 where a Save button was added because of sending email confirmation.

@PVince81 What's the way to go?

@PVince81
Copy link
Contributor

PVince81 commented Mar 1, 2017

whoever finishes first gets the merge

@PVince81
Copy link
Contributor

PVince81 commented Mar 1, 2017

@felixheidecke did your bad luck break travis today ?

Try rebasing

@lordelix
Copy link
Contributor Author

lordelix commented Mar 1, 2017

I tried no such thing today!?

@lordelix lordelix requested a review from PVince81 March 7, 2017 13:15
@lordelix
Copy link
Contributor Author

lordelix commented Mar 7, 2017

@davitol … well, this is as good as it gets right now. I could add the blur event also, but this gets fired too often in conjunction with the current event watchers. Checking if the content changed and save depending on the outcome should be a new issue.

@PVince81 fine with you?

@PVince81
Copy link
Contributor

PVince81 commented Mar 7, 2017

Fine with me if this works with IE11 also

@lordelix
Copy link
Contributor Author

lordelix commented Mar 7, 2017

Fine with me if this works with IE11 also

Japp – works fine ;-)

@PVince81 PVince81 merged commit df37bc1 into master Mar 7, 2017
@PVince81 PVince81 deleted the fh_input_autofill branch March 7, 2017 13:48
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants