Skip to content

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Mar 21, 2017

config.sample.php was updated to explicitly state that there detection in place to set mysql.utf8mb4

Description

Related Issue

fixes #27221

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @phisch and @bartv2 to be potential reviewers.

.htaccess Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣 💥 :fuck-you:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is still in there? I pushed a fix for this 😡

Copy link
Contributor

@PVince81 PVince81 Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ping me in your next PR and we can insta-merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see blow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

config.sample.php was updated to explicitly state that there detection in place to set mysql.utf8mb4
@mmattel
Copy link
Contributor

mmattel commented Mar 21, 2017

Great 👍

Q: if you need to run the ./occ db:convert-mysql-charset manually because of post setup upgrade, how is the config parameter handled afterwards?
Does it need a manual change in config.php, is it done automatically by occ, if not - is there a note beeing printed by the command to do so, what happens if the command run but the setting has not been changed?

@settermjd FYI

@DeepDiver1975
Copy link
Member Author

how is the config parameter handled afterwards?

the config parameter is set by the occ command

@PVince81
Copy link
Contributor

👍

@PVince81 PVince81 merged commit f410190 into master Mar 22, 2017
@PVince81 PVince81 deleted the fix-mb4-detection branch March 22, 2017 10:36
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while installing using mariadb

6 participants