New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the active navigation entry to 'files_index' is so wrong ... #27843

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
4 participants
@DeepDiver1975
Member

DeepDiver1975 commented May 9, 2017

Description

The app name of files should be files ... how magical ...

Related Issue

fixes #27839

How Has This Been Tested?

  • switch between files app and settings
  • choose different language to make sure translations work as well

Screenshots (if appropriate):

bildschirmfoto von 2017-05-09 15-31-22

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 9, 2017

@DeepDiver1975 DeepDiver1975 requested a review from PVince81 May 9, 2017

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol May 9, 2017

Contributor

👍 WFM

Contributor

davitol commented May 9, 2017

👍 WFM

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975
Member

DeepDiver1975 commented May 9, 2017

@individual-it any idea why this is falling apart? https://travis-ci.org/owncloud/core/jobs/230361342 THX

@individual-it

This comment has been minimized.

Show comment
Hide comment
@individual-it

individual-it May 9, 2017

Member

some funny internal error ether on travis or saucelabs.
Restarting the job did fix it

Member

individual-it commented May 9, 2017

some funny internal error ether on travis or saucelabs.
Restarting the job did fix it

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 9, 2017

Member

👍 code makes sense

Member

PVince81 commented May 9, 2017

👍 code makes sense

@DeepDiver1975 DeepDiver1975 merged commit c6525b1 into master May 9, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the fix-files-menu-name branch May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment