Skip to content

[stable10] Testing /remote.php/dav/meta/$fileId/v#30429

Closed
phil-davis wants to merge 1 commit into
stable10from
stable10-more-dav-versions-tests
Closed

[stable10] Testing /remote.php/dav/meta/$fileId/v#30429
phil-davis wants to merge 1 commit into
stable10from
stable10-more-dav-versions-tests

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

Backport #29637

@phil-davis
Copy link
Copy Markdown
Contributor Author

Note: this "achieves" backporting - getting the composer/json change back to stable10 (so as to make stable10 "the same as" master).

The original changes in WebDav.php added theVersionFolderOfFileIdContainsElements() and userRestoresVersionIndexOfFile() - but those need listVersionFolder()) which is in master but not yet in stable10. So when resolving conflicts, I kept all the new methods/steps from master. That ends up making the various new step definitions available to stable10 - even though they may or may not be relevant to application code currently in stable10.

dav-versions.feature does not exist yet in stable10 so none of the actual gherkin feature/scenarios get backported. That would have to happen with a backport of the original PR that created dav-versions.feature.

@phil-davis
Copy link
Copy Markdown
Contributor Author

Options:

  1. backport like in this PR; or
  2. backport without the new code in WebDav.php (i.e. backport just the rdx/behat-variables related infrastructure; or
  3. close this and only backport after dav-versions.feature and the related new functionality has been backported.

@DeepDiver1975
Copy link
Copy Markdown
Member

oh - I'm sorry - this whole dav versions feature is not yet in stable10. From my pov we don't need this.

@phil-davis
Copy link
Copy Markdown
Contributor Author

NP - rdx/behat-variables is not used anywhere in stable10 yet, so yes, it can come [if|when] the dav version feature is backported and then these extra dav versions tests on top of that.

@phil-davis phil-davis closed this Feb 9, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2018

Codecov Report

Merging #30429 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #30429   +/-   ##
===========================================
  Coverage       61.19%   61.19%           
  Complexity      18088    18088           
===========================================
  Files            1068     1068           
  Lines           60089    60089           
===========================================
  Hits            36774    36774           
  Misses          23315    23315

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aefb9f7...a7f1f2a. Read the comment docs.

@phil-davis phil-davis deleted the stable10-more-dav-versions-tests branch February 9, 2018 08:48
@lock
Copy link
Copy Markdown

lock Bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants