New hook system #3266
Merged
New hook system #3266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/hooks/basicemitter.php
Outdated
Contributor
There was a problem hiding this comment.
Your gist says removeListener for this function.
Contributor
|
Do you want to move the old class into legacy in this pull request as well? |
Contributor
|
👍 All tests passed. |
Contributor
Author
Member
|
🍻 for unit tests |
Member
|
@icewind1991 are you planing to push your gist to the dev docs? |
Member
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New hook system that allows better scoping of events, main advantage is better automated tests for classes using this system compared to OC_Hooks.
Not meant to replace the existing uses of OC_Hooks, instead meant for new classes that want to provide hooks
More info: https://gist.github.com/icewind1991/1e315e6e75c106406405
Required as part of the improved filesystem api I'm planning.
cc @MTGap @Raydiation @karlitschek @DeepDiver1975