Move share_external migration into the sharing app

[VicDeo]

Description

Subj

Related Issue

Fixes https://drone.owncloud.com/owncloud/update-testing/398/188

Motivation and Context

Wrong migration order for share_external table.

How Has This Been Tested?

1. install from master@8f3d6c810677d061ac3bf85d482d1ed9a4d4c462
2. git checkout fix-providerid-migration
3. php occ upgrade
4. describe oc_share_external;

Expected
remote_id | varchar(255)

Actual
remote_id | bigint

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #35100 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #35100      +/-   ##
============================================
+ Coverage     65.45%   65.46%   +<.01%     
- Complexity    18633    18635       +2     
============================================
  Files          1216     1217       +1     
  Lines         70553    70551       -2     
  Branches       1296     1296              
============================================
+ Hits          46183    46185       +2     
+ Misses        23993    23989       -4     
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	53.49% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.84% <0%> (ø)	18635 <2> (+2)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...aring/appinfo/Migrations/Version20190410160725.php	100% <ø> (+25%)	2 <0> (ø)	⬇️
...aring/appinfo/Migrations/Version20190426123324.php	0% <0%> (ø)	2 <2> (?)
lib/private/Server.php	86.68% <0%> (+0.11%)	253% <0%> (ø)	⬇️
lib/private/Files/View.php	84.6% <0%> (+0.3%)	398% <0%> (ø)	⬇️
lib/private/DB/Connection.php	66.17% <0%> (+0.73%)	49% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432dd0c...2ba3d08. Read the comment docs.

[codecov]

Codecov Report

Merging #35100 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #35100      +/-   ##
============================================
+ Coverage     65.45%   65.46%   +<.01%     
- Complexity    18633    18635       +2     
============================================
  Files          1216     1217       +1     
  Lines         70553    70551       -2     
  Branches       1296     1296              
============================================
+ Hits          46183    46184       +1     
+ Misses        23993    23990       -3     
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	53.49% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.84% <0%> (ø)	18635 <2> (+2)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...aring/appinfo/Migrations/Version20190410160725.php	100% <ø> (+25%)	2 <0> (ø)	⬇️
...aring/appinfo/Migrations/Version20190426123324.php	0% <0%> (ø)	2 <2> (?)
lib/private/Files/View.php	84.6% <0%> (+0.3%)	398% <0%> (ø)	⬇️
lib/private/DB/Connection.php	66.17% <0%> (+0.73%)	49% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432dd0c...2ba3d08. Read the comment docs.

[phil-davis]

LGTM

[phil-davis]

@PVince81 please review and override the codecov result.
It would be good to get this merged today so that the overnight update-testing run will be happy again.

Note: PR #35002 has not yet been back-ported to stable10. When it is, then this PR also needs backporting.

[PVince81]

👍

[VicDeo]

Stable10: #35122