Skip to content

[stable10] Backport of The recipient of internal share should not inc…#35475

Merged
sharidas merged 1 commit intostable10from
share-permission-fix-stable10
Jun 11, 2019
Merged

[stable10] Backport of The recipient of internal share should not inc…#35475
sharidas merged 1 commit intostable10from
share-permission-fix-stable10

Conversation

@sharidas
Copy link
Copy Markdown
Contributor

…rease permission

The recipient of internal share, should not be able
to increase the permission.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

When an internal/regular share is created by say user1 to user2, the user2 should not be allowed to increase the permissions granted by user1. The UI prevents it. But by using ocs api, its possible to increase the permision. This pr addresses the issue.

Related Issue

  • Fixes <issue_link>

Motivation and Context

The user who is not the owner of the share shouldn't be allowed to increase the permission of the share.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

…rease permission

The recipient of internal share, should not be able
to increase the permission.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas self-assigned this Jun 11, 2019
@sharidas sharidas added this to the development milestone Jun 11, 2019
@sharidas sharidas requested review from jvillafanez and micbar June 11, 2019 06:53
@sharidas
Copy link
Copy Markdown
Contributor Author

Original PR: #35447

@sharidas sharidas merged commit bf0d450 into stable10 Jun 11, 2019
@delete-merged-branch delete-merged-branch Bot deleted the share-permission-fix-stable10 branch June 11, 2019 08:19
@phil-davis
Copy link
Copy Markdown
Contributor

PR for release-10.2.1 #35510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants