Skip to content

Fixup check_apache_module_enabled in run.sh#35478

Merged
DeepDiver1975 merged 1 commit intomasterfrom
run-sh-check_apache_module_enabled
Jun 11, 2019
Merged

Fixup check_apache_module_enabled in run.sh#35478
DeepDiver1975 merged 1 commit intomasterfrom
run-sh-check_apache_module_enabled

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

Description

  1. Use TESTING_APP_FED_URL when checking the remote federated server (this was a bug in the script)
  2. When reporting a problem checking if the module is enabled, mention which server it is (local or remote). That makes it easier to know what is wrong.
  3. Put new lines after the message (previously the messages got all concatenated on the same line, which was ugly)

Motivation and Context

How Has This Been Tested?

Local runs of acceptance tests with a PHP dev server so that I get messages like:

Script path: /home/phil/git/owncloud/core/tests/acceptance
Not using php inbuilt server for running scenario ...
Updating .htaccess for proper rewrites
Could not reliably determine if 'mod_rewrite' module is enabled on the local server, because the server does not seem to be running behind Apache.
Could not reliably determine if 'mod_rewrite' module is enabled on the remote server, because the server does not seem to be running behind Apache.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Copy Markdown
Contributor Author

Backport stable10 #35479

Comment thread tests/acceptance/run.sh
@DeepDiver1975 DeepDiver1975 merged commit ec3550d into master Jun 11, 2019
@delete-merged-branch delete-merged-branch Bot deleted the run-sh-check_apache_module_enabled branch June 11, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants