Skip to content

Add no skeleton steps in webUIRestrictSharing#35480

Merged
phil-davis merged 1 commit intomasterfrom
webUIRestrictSharing-no-external
Jun 11, 2019
Merged

Add no skeleton steps in webUIRestrictSharing#35480
phil-davis merged 1 commit intomasterfrom
webUIRestrictSharing-no-external

Conversation

@paurakhsharma
Copy link
Copy Markdown
Member

Description

Do not use skeleton files for webUIRestrictSharing to speed up CI

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Copy link
Copy Markdown
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paurakhsharma
Copy link
Copy Markdown
Member Author

Backport of: #35481

@phil-davis
Copy link
Copy Markdown
Contributor

CI fail:

  Scenario: Do not restrict users to only share with groups they are member of                                                 # /drone/src/tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature:45
    Given the setting "Restrict users to only share with groups they are member of" in the section "Sharing" has been disabled # WebUIGeneralContext::settingInSectionHasBeen()
    And the user browses to the files page                                                                                     # WebUIFilesContext::theUserBrowsesToTheFilesPage()
    When the user shares folder "simple-folder" with group "grp2" using the webUI                                              # WebUISharingContext::theUserSharesFileFolderWithGroupUsingTheWebUI()
    And the user re-logs in as "user3" using the webUI                                                                         # WebUILoginContext::theUserRelogsInUsingTheWebUI()
    Then folder "simple-folder (2)" should be listed on the webUI                                                              # WebUIFilesContext::fileFolderShouldBeListedOnTheWebUI()
      could not find  file 'simple-folder (2)' in current folder when it should be listed
      Failed asserting that null is not null.
SCENARIO RESULT: (fail)

user3 needs simple-folder or the test step could be modified to just look for simple-folder (not simple-folder (2)

@paurakhsharma paurakhsharma force-pushed the webUIRestrictSharing-no-external branch from d3d6494 to af22999 Compare June 11, 2019 11:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2019

Codecov Report

Merging #35480 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35480   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65991b3...af22999. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2019

Codecov Report

Merging #35480 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35480   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65991b3...af22999. Read the comment docs.

@phil-davis phil-davis merged commit a9e1f9f into master Jun 11, 2019
@delete-merged-branch delete-merged-branch Bot deleted the webUIRestrictSharing-no-external branch June 11, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants