Use Throwable as type hint in the exception callback#35713
Merged
DeepDiver1975 merged 1 commit intomasterfrom Jul 3, 2019
Merged
Use Throwable as type hint in the exception callback#35713DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
patrickjahns
reviewed
Jul 1, 2019
patrickjahns
suggested changes
Jul 1, 2019
cfbb985 to
32b9ac6
Compare
Codecov Report
@@ Coverage Diff @@
## master #35713 +/- ##
=========================================
Coverage ? 65.77%
Complexity ? 18777
=========================================
Files ? 1222
Lines ? 70872
Branches ? 1289
=========================================
Hits ? 46617
Misses ? 23877
Partials ? 378
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35713 +/- ##
=========================================
Coverage ? 65.77%
Complexity ? 18777
=========================================
Files ? 1222
Lines ? 70872
Branches ? 1289
=========================================
Hits ? 46617
Misses ? 23877
Partials ? 378
Continue to review full report at Codecov.
|
32b9ac6 to
039230d
Compare
Member
Author
|
@patrickjahns addressed - THX |
Member
Author
|
backport #35748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Not only exceptions can be thrown at runtime but also Errors. The common interface is \Throwable
Motivation and Context
Handle Errors properly as well
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: