Sort out api sharing test group membership to match with user_ldap#35746
Merged
phil-davis merged 1 commit intomasterfrom Jul 3, 2019
Merged
Sort out api sharing test group membership to match with user_ldap#35746phil-davis merged 1 commit intomasterfrom
phil-davis merged 1 commit intomasterfrom
Conversation
phil-davis
requested review from
dpakach,
haribhandari07,
individual-it,
paurakhsharma and
skshetry
phil-davis
force-pushed
the
api-sharing-tests-groups
branch
from
1a6e073 to
e17ced4
Compare
individual-it
approved these changes
Jul 3, 2019
Contributor
Author
|
Backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reviewed the
has been added to groupsteps in the sharing API test scenarios. Sorted them out so that they have group membership that matches what is used inuser_ldap.This should make
user_ldappass again, and improve some tests that were not really testing quite the right scenario when running inuser_ldapRelated Issue
owncloud/user_ldap#433 - fix it for now
owncloud/user_ldap#250 - we should make this better long-term
Motivation and Context
How Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: