Skip to content

[stable10] Add tests to create shares with only create,delete permissions#35924

Merged
phil-davis merged 1 commit intostable10from
stable10-share-file-create-delete
Jul 25, 2019
Merged

[stable10] Add tests to create shares with only create,delete permissions#35924
phil-davis merged 1 commit intostable10from
stable10-share-file-create-delete

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

Backport #35921

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2019

Codecov Report

Merging #35924 into stable10 will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35924      +/-   ##
==============================================
+ Coverage        64.7%    65.1%   +0.39%     
  Complexity      20197    20197              
==============================================
  Files            1302     1302              
  Lines           77158    77158              
  Branches         1301     1301              
==============================================
+ Hits            49926    50232     +306     
+ Misses          26847    26541     -306     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.29% <ø> (+0.43%) 20197 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 71.61% <0%> (+0.06%) 507% <0%> (ø) ⬇️
lib/private/Files/View.php 86.18% <0%> (+0.3%) 402% <0%> (ø) ⬇️
lib/private/Files/Storage/DAV.php 80.08% <0%> (+0.62%) 0% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.96%) 68% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.61% <0%> (+1.79%) 110% <0%> (ø) ⬇️
lib/private/AllConfig.php 95.89% <0%> (+2.05%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 100% <0%> (+2.73%) 17% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+3.5%) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 98.05% <0%> (+3.89%) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.89% <0%> (+3.94%) 21% <0%> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c099570...e2a7555. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2019

Codecov Report

Merging #35924 into stable10 will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35924      +/-   ##
==============================================
+ Coverage        64.7%    65.1%   +0.39%     
  Complexity      20197    20197              
==============================================
  Files            1302     1302              
  Lines           77158    77158              
  Branches         1301     1301              
==============================================
+ Hits            49926    50232     +306     
+ Misses          26847    26541     -306     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.29% <ø> (+0.43%) 20197 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 71.61% <0%> (+0.06%) 507% <0%> (ø) ⬇️
lib/private/Files/View.php 86.18% <0%> (+0.3%) 402% <0%> (ø) ⬇️
lib/private/Files/Storage/DAV.php 80.08% <0%> (+0.62%) 0% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.96%) 68% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.61% <0%> (+1.79%) 110% <0%> (ø) ⬇️
lib/private/AllConfig.php 95.89% <0%> (+2.05%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 100% <0%> (+2.73%) 17% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+3.5%) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 98.05% <0%> (+3.89%) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.89% <0%> (+3.94%) 21% <0%> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c099570...e2a7555. Read the comment docs.

@phil-davis phil-davis merged commit 9a9ea40 into stable10 Jul 25, 2019
@delete-merged-branch delete-merged-branch Bot deleted the stable10-share-file-create-delete branch July 25, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants