Skip to content

Document phoenix.baseUrl in config.sample.php #36007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeepDiver1975 merged 1 commit into from
Aug 16, 2019
Merged

Document phoenix.baseUrl in config.sample.php #36007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions config/config.sample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,15 @@
*/
'overwrite.cli.url' => '',

/**
* If phoenix.baseUrl is set, public and private links will be redirected to this
* url. Phoenix will handle these links accordingly.
Copy link
Copy Markdown
Contributor

@mmattel mmattel Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But only if the Phoenix App is loaded and enabled...
(Additional, add a comma for better readability: is set public --> is set, public)
Maybe to tell why this is necessary ? A brief reason would help.

Copy link
Copy Markdown
Member Author

@DeepDiver1975 DeepDiver1975 Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But only if the Phoenix App is loaded and enabled...

Phoenix can operate independent from owncloud - there is no need in having it installed as an app

Copy link
Copy Markdown
Contributor

@mmattel mmattel Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confusing, as there is an app on the marketplace...

Copy link
Copy Markdown
Member Author

@DeepDiver1975 DeepDiver1975 Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be precise:

  • phoenix can be installed as an owncloud app
  • phoenix can be installed on any web space (basically when installed as an app nothing else then serving the web assets is done by owncloud/apache)

*
* As an example, in case 'phoenix.baseUrl' is set to 'http://phoenix,example.com',
* the shared link 'http://ocx.example.com/index.php/s/THoQjwYYMJvXMdW' will be redirected
* by ownCloud to 'http://phoenix.example.com/index.html#//s/THoQjwYYMJvXMdW'.
*/
'phoenix.baseUrl' => '',
/**
* To have clean URLs without `/index.php` this parameter needs to be configured.
*
Expand Down