Conversation
1d77b6d to
3524305
Compare
jvillafanez
approved these changes
Aug 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #36111 +/- ##
=======================================
Coverage 54% 54%
=======================================
Files 63 63
Lines 7403 7403
Branches 1308 1308
=======================================
Hits 3998 3998
Misses 3019 3019
Partials 386 386
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #36111 +/- ##
=======================================
Coverage 54% 54%
=======================================
Files 63 63
Lines 7403 7403
Branches 1308 1308
=======================================
Hits 3998 3998
Misses 3019 3019
Partials 386 386
Continue to review full report at Codecov.
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects readability control in View. You can not use
&&operator when checking share permissions, use&(bitwise AND) instead.Related Issue
Motivation and Context
Fixing bugs.
How Has This Been Tested?
permission=2to a user.curl --user admin:admin "http://localhost/owncloud-core/ocs/v1.php/apps/files_sharing/api/v1/shares" --data 'path=/data.zip&shareType=0&shareWith=uu1&permissions=2'Screenshots (if appropriate):
Types of changes
Checklist: