Skip to content

fixed typos in 'phoenix.baseUrl' documentation#36152

Merged
sharidas merged 1 commit intomasterfrom
phoenix.baseUrl-typos
Sep 4, 2019
Merged

fixed typos in 'phoenix.baseUrl' documentation#36152
sharidas merged 1 commit intomasterfrom
phoenix.baseUrl-typos

Conversation

@individual-it
Copy link
Copy Markdown
Member

Description

follow up of #36007 fixing typos

Copy link
Copy Markdown
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks 👍

@sharidas
Copy link
Copy Markdown
Contributor

sharidas commented Sep 4, 2019

Restarted the CI.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2019

Codecov Report

Merging #36152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36152   +/-   ##
=======================================
  Coverage   54.01%   54.01%           
=======================================
  Files          63       63           
  Lines        7404     7404           
  Branches     1309     1309           
=======================================
  Hits         3999     3999           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ececf51...55f9e7e. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2019

Codecov Report

Merging #36152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36152   +/-   ##
=======================================
  Coverage   54.01%   54.01%           
=======================================
  Files          63       63           
  Lines        7404     7404           
  Branches     1309     1309           
=======================================
  Hits         3999     3999           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ececf51...55f9e7e. Read the comment docs.

@sharidas sharidas merged commit 45c65ca into master Sep 4, 2019
@delete-merged-branch delete-merged-branch Bot deleted the phoenix.baseUrl-typos branch September 4, 2019 12:27
@mmattel
Copy link
Copy Markdown
Contributor

mmattel commented Sep 4, 2019

is backporting necessary?

@phil-davis
Copy link
Copy Markdown
Contributor

is backporting necessary?

there is no stable10 any more - no more backporting needed in core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants