Skip to content

[10.4] Read only mount#36680

Merged
phil-davis merged 4 commits intorelease-10.4.0from
read_only_mount-for-10.4
Jan 3, 2020
Merged

[10.4] Read only mount#36680
phil-davis merged 4 commits intorelease-10.4.0from
read_only_mount-for-10.4

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

This is a "backport" of #36397 to the release-10.4 branch.

Hopefully this can get into 10.4

See the original master PR for details

@phil-davis phil-davis requested a review from micbar January 2, 2020 08:06
@phil-davis phil-davis self-assigned this Jan 2, 2020
@phil-davis phil-davis mentioned this pull request Jan 2, 2020
11 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 2, 2020

Codecov Report

Merging #36680 into release-10.4.0 will decrease coverage by <.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.4.0   #36680      +/-   ##
====================================================
- Coverage             64.68%   64.68%   -0.01%     
- Complexity            19121    19122       +1     
====================================================
  Files                  1269     1269              
  Lines                 74771    74778       +7     
  Branches               1320     1320              
====================================================
+ Hits                  48368    48372       +4     
- Misses                26015    26018       +3     
  Partials                388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <57.14%> (-0.01%) 19122 <0> (+1)
Impacted Files Coverage Δ Complexity Δ
apps/files_external/js/settings.js 51.84% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_external/lib/Command/ListCommand.php 68.04% <0%> (-0.41%) 0 <0> (ø)
apps/files_external/templates/settings.php 33.69% <100%> (+0.72%) 0 <0> (ø) ⬇️
lib/private/legacy/util.php 73.59% <60%> (-0.12%) 219 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d4e83...5f05076. Read the comment docs.

@phil-davis phil-davis changed the title Read only mount for 10.4 [10.4] Read only mount Jan 2, 2020
@phil-davis phil-davis force-pushed the read_only_mount-for-10.4 branch 2 times, most recently from cc06bb7 to 344742a Compare January 3, 2020 07:16
@phil-davis phil-davis force-pushed the read_only_mount-for-10.4 branch from 344742a to 5f05076 Compare January 3, 2020 10:47
@phil-davis phil-davis requested a review from mmattel January 3, 2020 11:56
@phil-davis phil-davis merged commit 524a619 into release-10.4.0 Jan 3, 2020
@delete-merged-branch delete-merged-branch Bot deleted the read_only_mount-for-10.4 branch January 3, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants