Use translations from lib and not from core#37056
Merged
phil-davis merged 2 commits intomasterfrom Mar 3, 2020
Merged
Conversation
ad46d89 to
a3e1d2a
Compare
karakayasemi
approved these changes
Mar 2, 2020
Contributor
|
@DeepDiver1975 unit test needs looking at. |
a3e1d2a to
96e7e11
Compare
Codecov Report
@@ Coverage Diff @@
## master #37056 +/- ##
=========================================
Coverage 64.75% 64.75%
Complexity 19138 19138
=========================================
Files 1270 1270
Lines 74915 74915
Branches 1329 1329
=========================================
Hits 48513 48513
Misses 26011 26011
Partials 391 391
Continue to review full report at Codecov.
|
phil-davis
approved these changes
Mar 3, 2020
Contributor
phil-davis
left a comment
There was a problem hiding this comment.
Unit test change LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The wrong translation context was used.
And default_language is taken into consideration
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: