[tests-only] skip new create-folder-with-create-button tests on oC10.8.0#39073
Merged
phil-davis merged 2 commits intomasterfrom Jul 29, 2021
Merged
[tests-only] skip new create-folder-with-create-button tests on oC10.8.0#39073phil-davis merged 2 commits intomasterfrom
phil-davis merged 2 commits intomasterfrom
Conversation
individual-it
approved these changes
Jul 29, 2021
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
PR #39056 added these tests yesterday, but we know that they will not work against a 10.8.0 system. Skip them in that case.
They will work on any later version - called 10.8.1 or 10.9.0 or whatever.
There were a few CLI tests that specified skip on 10.8. I changed that to 10.8.0.
That allows us to temporarily set the version in
masterto 10.8.1 and all these tagged tests will run. We can later make the release version whatever is needed (e.g. 10.9.0).How Has This Been Tested?
CI
Types of changes
Checklist: