Skip to content

fix: run update check in updatenotification app only when internet co… #41262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeepDiver1975 merged 1 commit into from
Jun 7, 2024
Merged

fix: run update check in updatenotification app only when internet co… #41262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/updatenotification/appinfo/app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
*
*/

if (\OC::$server->getConfig()->getSystemValue('has_internet_connection', true) !== true) {
return;
}

if (\OC::$server->getConfig()->getSystemValue('updatechecker', true) === true) {
$updater = new \OC\Updater\VersionCheck(
\OC::$server->getHTTPClientService(),
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/41262
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: No update check if not connected to the internet

In case an owncloud instance is not connected to the internet there is no need
in polling for updates in the update notification app.

https://github.com/owncloud/core/pull/41262