fix: catch new type error being thrown#41504
Merged
DeepDiver1975 merged 1 commit intomasterfrom Mar 17, 2026
Merged
Conversation
This is a new error that is thrown due to the update to php 8.3
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new error that is thrown due to the update to php 8.3
Description
The
copyKeysmethod isn't part of the interface and isn't likely available in most of the storages. It relies on the encryption wrapper (core/lib/private/Files/Storage/Wrapper/Encryption.php
Line 1108 in 04fbcb0
Related Issue
Found in owncloud/encryption#418 . Further details in that PR.
Motivation and Context
This is a quick and dirty solution to restore the previous behavior (from php 7.4) to make the tests from owncloud/encryption#418 pass
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: