Skip to content

fix: catch new type error being thrown#41504

Merged
DeepDiver1975 merged 1 commit intomasterfrom
encryption_copykeys_typeerror
Mar 17, 2026
Merged

fix: catch new type error being thrown#41504
DeepDiver1975 merged 1 commit intomasterfrom
encryption_copykeys_typeerror

Conversation

@jvillafanez
Copy link
Copy Markdown
Member

This is a new error that is thrown due to the update to php 8.3

Description

The copyKeys method isn't part of the interface and isn't likely available in most of the storages. It relies on the encryption wrapper (

protected function copyKeys($source, $target) {
) to stop the call from reaching the storage.

Related Issue

Found in owncloud/encryption#418 . Further details in that PR.

Motivation and Context

This is a quick and dirty solution to restore the previous behavior (from php 7.4) to make the tests from owncloud/encryption#418 pass

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

This is a new error that is thrown due to the update to php 8.3
@jvillafanez jvillafanez self-assigned this Mar 17, 2026
@update-docs
Copy link
Copy Markdown

update-docs Bot commented Mar 17, 2026

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 merged commit a9d3918 into master Mar 17, 2026
12 checks passed
@DeepDiver1975 DeepDiver1975 deleted the encryption_copykeys_typeerror branch March 17, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants