fix(occ): prevent params command key from overriding validated allowlist command#41577
Open
DeepDiver1975 wants to merge 2 commits into
Open
fix(occ): prevent params command key from overriding validated allowlist command#41577DeepDiver1975 wants to merge 2 commits into
DeepDiver1975 wants to merge 2 commits into
Conversation
…ist command OccController::execute() validated the URL-path $command against the allowlist, then called array_merge(["command"=>$command], $params). PHP's array_merge with string keys lets later values overwrite earlier ones, so a "command" key in the POST body $params silently replaced the validated command, allowing execution of any occ command. Add unset($params["command"]) before the merge to strip any attacker-supplied command key, ensuring the validated value is always what reaches Symfony Console. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OccController::execute()validated the URL-path$commandagainst the allowlist, then merged it with user-supplied$paramsviaarray_merge(['command' => $command], $params)array_mergewith string keys causes later duplicates to overwrite earlier ones — acommandkey in the POST body bypassed the allowlist entirelyunset($params['command'])before the merge; one-line change, complete protectionSecurity Impact
Critical — authenticated updater callers with
updater.secret+ localhost access can execute anyocccommand (user:resetpassword, config:system:set, encryption:decrypt-all, etc.) regardless of the allowlistTest plan
testParamsCommandKeyCannotOverrideValidatedCommandsendsuser:resetpasswordin params while URL saysstatus; asserts console receivesstatus— fails without fixmake test TEST_PHP_SUITE=core/Controller🤖 Generated with Claude Code